Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'cloud.project.id' for GCP metadata to be the 'project-id' #3316

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Sep 8, 2023

Closes: #3311

@trentm trentm marked this pull request as ready for review September 8, 2023 23:51
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

/test

JonasKunz
JonasKunz previously approved these changes Sep 13, 2023
Copy link
Contributor

@JonasKunz JonasKunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@JonasKunz JonasKunz enabled auto-merge (squash) September 13, 2023 07:56
@JonasKunz JonasKunz merged commit 481ee25 into elastic:main Sep 13, 2023
11 checks passed
@trentm trentm deleted the trentm/gcp-metadata-cloud-project-id branch September 13, 2023 16:36
schikin pushed a commit to schikin/apm-agent-java that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[META 826] changes to metadata.cloud.project.* fields collected for GCP
3 participants